ACPI: video_device_list corruption (98934def) · Commits · 戴 / test

The ->cap fields of struct acpi_video_device and struct acpi_video_bus are 1B each, not 4B. The oversized memset()'s corrupted the subsequent list_head fields. This resulted in silent corruption without CONFIG_DEBUG_LIST and BUG's with it. This patch uses sizeof() to pass the proper bounds to the memset() calls and thereby correct the bugs. Signed-off-by:

William Irwin <wli@holomorphy.com> Acked-by:

Mikael Pettersson <mikpe@it.uu.se> Signed-off-by:

Len Brown <len.brown@intel.com>

drivers/acpi/video.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -577,7 +577,7 @@ static void acpi_video_device_find_cap(struct acpi_video_device *device)
		struct acpi_video_device_brightness *br = NULL;


		memset(&device->cap, 0, 4);
		memset(&device->cap, 0, sizeof(device->cap));

		if (ACPI_SUCCESS(acpi_get_handle(device->dev->handle, "_ADR", &h_dummy1))) {
		device->cap._ADR = 1;
		@@ -697,7 +697,7 @@ static void acpi_video_bus_find_cap(struct acpi_video_bus *video)
		{
		acpi_handle h_dummy1;

		memset(&video->cap, 0, 4);
		memset(&video->cap, 0, sizeof(video->cap));
		if (ACPI_SUCCESS(acpi_get_handle(video->device->handle, "_DOS", &h_dummy1))) {
		video->cap._DOS = 1;
		}

Admin message