Unverified Commit 98910e1d authored Dec 04, 2019 by Colin Ian King Committed by Mark Brown Dec 24, 2019

ASoC: SOF: imx8: fix memory allocation failure check on priv->pd_dev



The memory allocation failure check for priv->pd_dev is incorrectly
pointer checking priv instead of priv->pd_dev. Fix this.

Addresses-Coverity: ("Logically dead code")
Fixes: 202acc56 ("ASoC: SOF: imx: Add i.MX8 HW support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20191204124816.1415359-1-colin.king@canonical.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 921162c8

sound/soc/sof/imx/imx8.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -209,7 +209,7 @@ static int imx8_probe(struct snd_sof_dev *sdev)

		priv->pd_dev = devm_kmalloc_array(&pdev->dev, priv->num_domains,
		sizeof(*priv->pd_dev), GFP_KERNEL);
		if (!priv)
		if (!priv->pd_dev)
		return -ENOMEM;

		priv->link = devm_kmalloc_array(&pdev->dev, priv->num_domains,

Admin message