Commit 9889707b authored Jul 23, 2019 by Slawomir Laba Committed by Jeff Kirsher Aug 22, 2019

i40e: Fix crash caused by stress setting of VF MAC addresses



Add update to the VSI pointer passed to the i40e_set_vf_mac function.
If VF is in reset state the driver waits in i40e_set_vf_mac function
for the reset to be complete, yet after reset the vsi pointer
that was passed into this function is no longer valid.

The patch updates local VSI pointer directly from pf->vsi array,
by using the id stored in VF pointer (lan_vsi_idx).

Without this commit the driver might occasionally invoke general
protection fault in kernel and disable the OS entirely.

Signed-off-by: Slawomir Laba <slawomirx.laba@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 1e0303fd

drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -3967,10 +3967,15 @@ int i40e_ndo_set_vf_mac(struct net_device netdev, int vf_id, u8 mac)
		/* When the VF is resetting wait until it is done.
		* It can take up to 200 milliseconds,
		* but wait for up to 300 milliseconds to be safe.
		* If the VF is indeed in reset, the vsi pointer has
		* to show on the newly loaded vsi under pf->vsi[id].
		*/
		for (i = 0; i < 15; i++) {
		if (test_bit(I40E_VF_STATE_INIT, &vf->vf_states))
		if (test_bit(I40E_VF_STATE_INIT, &vf->vf_states)) {
		if (i > 0)
		vsi = pf->vsi[vf->lan_vsi_idx];
		break;
		}
		msleep(20);
		}
		if (!test_bit(I40E_VF_STATE_INIT, &vf->vf_states)) {

Admin message