Commit 986e3f6e authored Jan 23, 2011 by Jesper Juhl Committed by David S. Miller Jan 24, 2011

USB NET KL5KUSB101: Fix mem leak in error path of kaweth_download_firmware()



We will leak the storage allocated by request_firmware() if the size of
the firmware is greater than KAWETH_FIRMWARE_BUF_SIZE.
This removes the leak by calling release_firmware() before we return
-ENOSPC.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 2321f3b4

drivers/net/usb/kaweth.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -406,6 +406,7 @@ static int kaweth_download_firmware(struct kaweth_device *kaweth,

		if (fw->size > KAWETH_FIRMWARE_BUF_SIZE) {
		err("Firmware too big: %zu", fw->size);
		release_firmware(fw);
		return -ENOSPC;
		}
		data_len = fw->size;

Admin message