Commit 98562ad8 authored Feb 04, 2011 by Dmitry Torokhov Committed by Linus Torvalds Feb 21, 2011

module: explicitly align module_version_attribute structure



We force particular alignment when we generate attribute structures
when generation MODULE_VERSION() data and we need to make sure that
this alignment is followed when we iterate over these structures,
otherwise we may crash on platforms whose natural alignment is not
sizeof(void *), such as m68k.

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Dmitry Torokhov <dtor@vmware.com>
[ There are more issues here, but the fixes are incredibly ugly - Linus ]
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 5fb24b81

include/linux/module.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -62,7 +62,7 @@ struct module_version_attribute {
		struct module_attribute mattr;
		const char *module_name;
		const char *version;
		};
		} __attribute__ ((__aligned__(sizeof(void *))));

		struct module_kobject
		{

Admin message