line6: fix memory leaks in line6_init_midi() (982d6ab5) · Commits · 戴 / test

If the first call to line6_midibuf_init() fails we'll leak a little bit of memory. If the second call fails we'll leak a bit more. This happens when we return from the function and the local variable 'line6midi' goes out of scope. Signed-off-by:

Jesper Juhl <jj@chaosbits.net> Signed-off-by:

Greg Kroah-Hartman <gregkh@suse.de>

drivers/staging/line6/midi.c

+7 −2

Original line number	Diff line number	Diff line
		@@ -391,12 +391,17 @@ int line6_init_midi(struct usb_line6 *line6)
		return -ENOMEM;

		err = line6_midibuf_init(&line6midi->midibuf_in, MIDI_BUFFER_SIZE, 0);
		if (err < 0)
		if (err < 0) {
		kfree(line6midi);
		return err;
		}

		err = line6_midibuf_init(&line6midi->midibuf_out, MIDI_BUFFER_SIZE, 1);
		if (err < 0)
		if (err < 0) {
		kfree(line6midi->midibuf_in.buf);
		kfree(line6midi);
		return err;
		}

		line6midi->line6 = line6;
		line6midi->midi_mask_transmit = 1;

Admin message