Commit 982bb705 authored Mar 12, 2020 by Tero Kristo Committed by Wim Van Sebroeck Mar 18, 2020

watchdog: reset last_hw_keepalive time at start



Currently the watchdog core does not initialize the last_hw_keepalive
time during watchdog startup. This will cause the watchdog to be pinged
immediately if enough time has passed from the system boot-up time, and
some types of watchdogs like K3 RTI does not like this.

To avoid the issue, setup the last_hw_keepalive time during watchdog
startup.

Signed-off-by: Tero Kristo <t-kristo@ti.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20200302200426.6492-3-t-kristo@ti.com


Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>

parent 436867b6

drivers/watchdog/watchdog_dev.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -282,6 +282,7 @@ static int watchdog_start(struct watchdog_device *wdd)
		if (err == 0) {
		set_bit(WDOG_ACTIVE, &wdd->status);
		wd_data->last_keepalive = started_at;
		wd_data->last_hw_keepalive = started_at;
		watchdog_update_worker(wdd);
		}

Admin message