Commit 981a2e3e authored Apr 25, 2017 by Gilad Ben-Yossef Committed by Herbert Xu May 18, 2017

crypto: tcrypt - don't disable irqs and wait



The tcrypt AEAD cycles speed tests disables irqs during the test, which is
broken at the very least since commit
'1425d2d1 ("crypto: tcrypt - Fix AEAD speed tests")'
adds a wait for completion as part of the test and probably since
switching to the new AEAD API.

While the result of taking a cycle count diff may not mean much on SMP
systems if the task migrates, it's good enough for tcrypt being the quick
& dirty dev tool it is. It's also what all the other (i.e. hash) cycle
speed tests do.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Reported-by: Ofir Drang <ofir.drang@arm.com>
Reviewed-by: Horia Geantă <horia.geanta@nxp.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 9933e113

crypto/tcrypt.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -138,8 +138,6 @@ static int test_aead_cycles(struct aead_request *req, int enc, int blen)
		int ret = 0;
		int i;

		local_irq_disable();

		/* Warm-up run. */
		for (i = 0; i < 4; i++) {
		if (enc)
		@@ -169,8 +167,6 @@ static int test_aead_cycles(struct aead_request *req, int enc, int blen)
		}

		out:
		local_irq_enable();

		if (ret == 0)
		printk("1 operation in %lu cycles (%d bytes)\n",
		(cycles + 4) / 8, blen);

Admin message