Commit 98161443 authored Sep 26, 2019 by Pawel Laszczak Committed by Greg Kroah-Hartman Oct 04, 2019

usb: cdns3: Fix sheduling with locks held.



Patch fix issue in cdns3_ep0_feature_handle_device function.

The function usleep_range can't be used there because this function is
called with locks held and IRQs disabled in
cdns3_device_thread_irq_handler().

To resolve this issue patch replaces usleep_range with mdelay.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Fixes: 7733f6c3 ("usb: cdns3: Add Cadence USB3 DRD Driver")
Reviewed-by: Peter Chen <peter.chen@nxp.com>
Link: https://lore.kernel.org/r/1569484721-4424-1-git-send-email-pawell@cadence.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 5f318dad

drivers/usb/cdns3/ep0.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -332,7 +332,7 @@ static int cdns3_ep0_feature_handle_device(struct cdns3_device *priv_dev,
		* for sending status stage.
		* This time should be less then 3ms.
		*/
		usleep_range(1000, 2000);
		mdelay(1);
		cdns3_set_register_bit(&priv_dev->regs->usb_cmd,
		USB_CMD_STMODE \|
		USB_STS_TMODE_SEL(tmode - 1));

Admin message