Commit 98086a95 authored Nov 20, 2009 by Bruce Allan Committed by David S. Miller Nov 21, 2009

e1000e: improper return code signage



The e1000_get_cable_length_82577() should return a negative value upon
error.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7ea9655f

drivers/net/e1000e/phy.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3137,7 +3137,7 @@ s32 e1000_get_cable_length_82577(struct e1000_hw *hw)
		I82577_DSTATUS_CABLE_LENGTH_SHIFT;

		if (length == E1000_CABLE_LENGTH_UNDEFINED)
		ret_val = E1000_ERR_PHY;
		ret_val = -E1000_ERR_PHY;

		phy->cable_length = length;

Admin message