Commit 98005e8c authored Mar 07, 2019 by Vadim Bendebury Committed by Linus Torvalds Mar 07, 2019

checkpatch: allow reporting C99 style comments

Presently C99 style comments are removed unconditionally before actual
patch validity check happens.  This is a problem for some third party
projects which use checkpatch.pl but do not allow C99 style comments.

This patch adds yet another variable, named C99_COMMENT_TOLERANCE.  If
it is included in the --ignore command line or config file options list,
C99 comments in the patch are reported as errors.

Tested by processing a patch with a C99 style comment, it passes the
check just fine unless '--ignore C99_COMMENT_TOLERANCE' is present in
.checkpatch.conf.

Link: http://lkml.kernel.org/r/20190110224957.25008-1-vbendeb@chromium.org


Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent e29a70f1

scripts/checkpatch.pl

+2 −1

Original line number	Diff line number	Diff line
		@@ -61,7 +61,7 @@ my $codespellfile = "/usr/share/codespell/dictionary.txt";
		my $conststructsfile = "$D/const_structs.checkpatch";
		my $typedefsfile = "";
		my $color = "auto";
		my $allow_c99_comments = 1;
		my $allow_c99_comments = 1; # Can be overridden by --ignore C99_COMMENT_TOLERANCE

		sub help {
		my ($exitcode) = @_;
		@@ -1021,6 +1021,7 @@ if ($git) {
		}

		my $vname;
		$allow_c99_comments = !defined $ignore_type{"C99_COMMENT_TOLERANCE"};
		for my $filename (@ARGV) {
		my $FILE;
		if ($git) {

Admin message