Commit 97e61751 authored Jul 23, 2020 by Paolo Abeni Committed by David S. Miller Jul 23, 2020

subflow: use rsk_ops->send_reset()



tcp_send_active_reset() is more prone to transient errors
(memory allocation or xmit queue full): in stress conditions
the kernel may drop the egress packet, and the client will be
stuck.

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Tested-by: Christoph Paasch <cpaasch@apple.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent b7514694

net/mptcp/subflow.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -524,9 +524,9 @@ out:
		dispose_child:
		subflow_drop_ctx(child);
		tcp_rsk(req)->drop_req = true;
		tcp_send_active_reset(child, GFP_ATOMIC);
		inet_csk_prepare_for_destroy_sock(child);
		tcp_done(child);
		req->rsk_ops->send_reset(sk, skb);

		/* The last child reference will be released by the caller */
		return child;

Admin message