Commit 97dfb203 authored by Mike Snitzer's avatar Mike Snitzer
Browse files

dm cache policy smq: cleanup free_target_met() and clean_target_met() 



Depending on the passed @idle arg, there may be no need to calculate
'nr_free' or 'nr_clean' respectively in free_target_met() and
clean_target_met().

Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
parent ce1d64e8

drivers/md/dm-cache-policy-smq.c

+13 −11
Original line number Diff line number Diff line
@@ -1120,28 +1120,30 @@ static bool clean_target_met(struct smq_policy *mq, bool idle) 
	 * Cache entries may not be populated.  So we cannot rely on the

	 * size of the clean queue.

	 */

	unsigned nr_clean = from_cblock(mq->cache_size) - q_size(&mq->dirty);

	unsigned nr_clean;



	if (idle)

	if (idle) {

		/*

		 * We'd like to clean everything.

		 */

		return q_size(&mq->dirty) == 0u;

	else

	}



	nr_clean = from_cblock(mq->cache_size) - q_size(&mq->dirty);

	return (nr_clean + btracker_nr_writebacks_queued(mq->bg_work)) >=

		percent_to_target(mq, CLEAN_TARGET);

}



static bool free_target_met(struct smq_policy *mq, bool idle)

{

	unsigned nr_free = from_cblock(mq->cache_size) -

			   mq->cache_alloc.nr_allocated;

	unsigned nr_free;



	if (idle)

	if (!idle)

		return true;



	nr_free = from_cblock(mq->cache_size) - mq->cache_alloc.nr_allocated;

	return (nr_free + btracker_nr_demotions_queued(mq->bg_work)) >=

		percent_to_target(mq, FREE_TARGET);

	else

		return true;

}



/*----------------------------------------------------------------*/

CRA Git | Maintained and supported by SUSTech CRA and CCSE