Commit 97ce86f9 authored Apr 01, 2020 by Mateusz Nosek Committed by Linus Torvalds Apr 02, 2020

mm/page_alloc.c: micro-optimisation Remove unnecessary branch



Previously if branch condition was false, the assignment was not executed.
The assignment can be safely executed even when the condition is false
and it is not incorrect as it assigns the value of 'nodemask' to
'ac.nodemask' which already has the same value.

So as the assignment can be executed unconditionally, the branch can be
removed.

Signed-off-by: Mateusz Nosek <mateusznosek0@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Link: http://lkml.kernel.org/r/20200307225335.31300-1-mateusznosek0@gmail.com


Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 76089d00

mm/page_alloc.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -4751,7 +4751,6 @@ __alloc_pages_nodemask(gfp_t gfp_mask, unsigned int order, int preferred_nid,
		* Restore the original nodemask if it was potentially replaced with
		* &cpuset_current_mems_allowed to optimize the fast-path attempt.
		*/
		if (unlikely(ac.nodemask != nodemask))
		ac.nodemask = nodemask;

		page = __alloc_pages_slowpath(alloc_mask, order, &ac);

Admin message