iop: Program outbound windows using the correct definitions (97c46048) · Commits · 戴 / test

The outbound translate registers should be programmed with the bus addresses that are defined in the header files, rather than the physical address. Currently it doesn't matter because they're identical, but the headers currently allow them to be different, and not using the right macros here means that people are in for a surprise if they change them. Cc: Lennert Buytenhek <kernel@wantstofly.org> Acked-by:

Dan Williams <dan.j.williams@intel.com> Signed-off-by:

Russell King <rmk+kernel@arm.linux.org.uk>

arch/arm/plat-iop/pci.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -253,11 +253,11 @@ void __init iop3xx_atu_setup(void)
		*IOP3XX_IATVR2 = PHYS_OFFSET;

		/* Outbound window 0 */
		*IOP3XX_OMWTVR0 = IOP3XX_PCI_LOWER_MEM_PA;
		*IOP3XX_OMWTVR0 = IOP3XX_PCI_LOWER_MEM_BA;
		*IOP3XX_OUMWTVR0 = 0;

		/* Outbound window 1 */
		*IOP3XX_OMWTVR1 = IOP3XX_PCI_LOWER_MEM_PA + IOP3XX_PCI_MEM_WINDOW_SIZE;
		*IOP3XX_OMWTVR1 = IOP3XX_PCI_LOWER_MEM_BA + IOP3XX_PCI_MEM_WINDOW_SIZE;
		*IOP3XX_OUMWTVR1 = 0;

		/* BAR 3 ( Disabled ) */
		@@ -268,7 +268,7 @@ void __init iop3xx_atu_setup(void)

		/* Setup the I/O Bar
		*/
		*IOP3XX_OIOWTVR = IOP3XX_PCI_LOWER_IO_PA;;
		*IOP3XX_OIOWTVR = IOP3XX_PCI_LOWER_IO_BA;

		/* Enable inbound and outbound cycles
		*/

Admin message