Commit 97bebbcd authored Jul 30, 2020 by Masahiro Yamada

Revert "kconfig: qconf: Change title for the item window"



This reverts commit 5752ff07.

It added dead code to ConfigList:ConfigList().

The constructor of ConfigList has the initializer, mode(singleMode).

    if (mode == symbolMode)
           setHeaderLabels(QStringList() << "Item" << "Name" << "N" << "M" << "Y" << "Value");
    else
           setHeaderLabels(QStringList() << "Option" << "Name" << "N" << "M" << "Y" << "Value");

... always takes the else part.

The change to ConfigList::updateSelection() is strange too.
When you click the split view icon for the first time, the titles in
both windows show "Option". After you click something in the right
window, the title suddenly changes to "Item".

ConfigList::updateSelection() is not the right place to do this,
at least. It was not a good idea, I think.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

parent ce02397f

scripts/kconfig/qconf.cc

+1 −9

Original line number	Diff line number	Diff line
		@@ -307,9 +307,6 @@ ConfigList::ConfigList(ConfigView* p, const char *name)
		setVerticalScrollMode(ScrollPerPixel);
		setHorizontalScrollMode(ScrollPerPixel);

		if (mode == symbolMode)
		setHeaderLabels(QStringList() << "Item" << "Name" << "N" << "M" << "Y" << "Value");
		else
		setHeaderLabels(QStringList() << "Option" << "Name" << "N" << "M" << "Y" << "Value");

		connect(this, SIGNAL(itemSelectionChanged(void)),
		@@ -391,11 +388,6 @@ void ConfigList::updateSelection(void)
		struct menu *menu;
		enum prop_type type;

		if (mode == symbolMode)
		setHeaderLabels(QStringList() << "Item" << "Name" << "N" << "M" << "Y" << "Value");
		else
		setHeaderLabels(QStringList() << "Option" << "Name" << "N" << "M" << "Y" << "Value");

		if (selectedItems().count() == 0)
		return;

Admin message