ext4: mballoc: avoid 20-argument function call (97b4af2f) · Commits · 戴 / test

Making a function call with 20 arguments is rather expensive in both stack and .text. In this case, doing the formatting manually doesn't make it any less readable, so we might as well save 155 bytes of .text and 112 bytes of stack. Signed-off-by:

Rasmus Villemoes <linux@rasmusvillemoes.dk>

fs/ext4/mballoc.c

+3 −6

Original line number	Diff line number	Diff line
		@@ -2275,12 +2275,9 @@ static int ext4_mb_seq_groups_show(struct seq_file seq, void v)

		group--;
		if (group == 0)
		seq_printf(seq, "#%-5s: %-5s %-5s %-5s "
		"[ %-5s %-5s %-5s %-5s %-5s %-5s %-5s "
		"%-5s %-5s %-5s %-5s %-5s %-5s %-5s ]\n",
		"group", "free", "frags", "first",
		"2^0", "2^1", "2^2", "2^3", "2^4", "2^5", "2^6",
		"2^7", "2^8", "2^9", "2^10", "2^11", "2^12", "2^13");
		seq_puts(seq, "#group: free frags first ["
		" 2^0 2^1 2^2 2^3 2^4 2^5 2^6 "
		" 2^7 2^8 2^9 2^10 2^11 2^12 2^13 ]");

		i = (sb->s_blocksize_bits + 2) * sizeof(sg.info.bb_counters[0]) +
		sizeof(struct ext4_group_info);

Admin message