Commit 97a4f1d7 authored Jun 26, 2014 by Bob Peterson Committed by Steven Whitehouse Jul 18, 2014

GFS2: Allow caching of glocks for flock

This patch removes the GLF_NOCACHE flag from the glocks associated with
flocks. There should be no good reason not to cache glocks for flocks:
they only force the glock to be demoted before they can be reacquired,
which can slow down performance and even cause glock hangs, especially
in cases where the flocks are held in Shared (SH) mode.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

parent 5bef3e7c

fs/gfs2/file.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -981,7 +981,7 @@ static int do_flock(struct file file, int cmd, struct file_lock fl)
		int error = 0;

		state = (fl->fl_type == F_WRLCK) ? LM_ST_EXCLUSIVE : LM_ST_SHARED;
		flags = (IS_SETLKW(cmd) ? 0 : LM_FLAG_TRY) \| GL_EXACT \| GL_NOCACHE;
		flags = (IS_SETLKW(cmd) ? 0 : LM_FLAG_TRY) \| GL_EXACT;

		mutex_lock(&fp->f_fl_mutex);

Admin message