Commit 97982782 authored Jun 11, 2020 by Tuong Lien Committed by David S. Miller Jun 11, 2020

tipc: fix NULL pointer dereference in tipc_disc_rcv()



When a bearer is enabled, we create a 'tipc_discoverer' object to store
the bearer related data along with a timer and a preformatted discovery
message buffer for later probing... However, this is only carried after
the bearer was set 'up', that left a race condition resulting in kernel
panic.

It occurs when a discovery message from a peer node is received and
processed in bottom half (since the bearer is 'up' already) just before
the discoverer object is created but is now accessed in order to update
the preformatted buffer (with a new trial address, ...) so leads to the
NULL pointer dereference.

We solve the problem by simply moving the bearer 'up' setting to later,
so make sure everything is ready prior to any message receiving.

Acked-by: Jon Maloy <jmaloy@redhat.com>
Signed-off-by: Tuong Lien <tuong.t.lien@dektech.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c9aa81fa

net/tipc/bearer.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -316,7 +316,6 @@ static int tipc_enable_bearer(struct net net, const char name,
		b->domain = disc_domain;
		b->net_plane = bearer_id + 'A';
		b->priority = prio;
		test_and_set_bit_lock(0, &b->up);
		refcount_set(&b->refcnt, 1);

		res = tipc_disc_create(net, b, &b->bcast_addr, &skb);
		@@ -326,6 +325,7 @@ static int tipc_enable_bearer(struct net net, const char name,
		goto rejected;
		}

		test_and_set_bit_lock(0, &b->up);
		rcu_assign_pointer(tn->bearer_list[bearer_id], b);
		if (skb)
		tipc_bearer_xmit_skb(net, bearer_id, skb, &b->bcast_addr);

Admin message