Commit 978b4053 authored Nov 17, 2009 by Peter Zijlstra Committed by Linus Torvalds Nov 17, 2009

fcntl: rename F_OWNER_GID to F_OWNER_PGRP



This is for consistency with various ioctl() operations that include the
suffix "PGRP" in their names, and also for consistency with PRIO_PGRP,
used with setpriority() and getpriority().  Also, using PGRP instead of
GID avoids confusion with the common abbreviation of "group ID".

I'm fine with anything that makes it more consistent, and if PGRP is what
is the predominant abbreviation then I see no need to further confuse
matters by adding a third one.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Michael Kerrisk <mtk.manpages@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 9ebd4eba

fs/fcntl.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -284,7 +284,7 @@ static int f_setown_ex(struct file *filp, unsigned long arg)
		type = PIDTYPE_PID;
		break;

		case F_OWNER_GID:
		case F_OWNER_PGRP:
		type = PIDTYPE_PGID;
		break;

		@@ -321,7 +321,7 @@ static int f_getown_ex(struct file *filp, unsigned long arg)
		break;

		case PIDTYPE_PGID:
		owner.type = F_OWNER_GID;
		owner.type = F_OWNER_PGRP;
		break;

		default:

include/asm-generic/fcntl.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -89,7 +89,7 @@

		#define F_OWNER_TID 0
		#define F_OWNER_PID 1
		#define F_OWNER_GID 2
		#define F_OWNER_PGRP 2

		struct f_owner_ex {
		int type;

Admin message