Commit 9784c996 authored Apr 23, 2020 by Stephen Boyd Committed by Bartosz Golaszewski Apr 24, 2020

gpiolib: devprop: Warn if gpio-line-names is too long



Some DT authors (including myself) have messed up the length of
gpio-line-names and made it longer than it should be. Add a warning here
so that developers can figure out that they've messed up their DT and
should fix it.

Cc: Alexandru M Stan <amstan@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

parent aa58a21a

drivers/gpio/gpiolib-devprop.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -37,8 +37,11 @@ void devprop_gpiochip_set_names(struct gpio_chip *chip,
		if (count < 0)
		return;

		if (count > gdev->ngpio)
		if (count > gdev->ngpio) {
		dev_warn(&gdev->dev, "gpio-line-names is length %d but should be at most length %d",
		count, gdev->ngpio);
		count = gdev->ngpio;
		}

		names = kcalloc(count, sizeof(*names), GFP_KERNEL);
		if (!names)

Admin message