Commit 977bd8a9 authored Jun 24, 2015 by Grygorii Strashko Committed by Linus Walleij Jul 16, 2015

gpio: omap: add missed spin_unlock_irqrestore in omap_gpio_irq_type



Add missed spin_unlock_irqrestore in omap_gpio_irq_type when
omap_set_gpio_triggering() is failed.

It fixes static checker warning:

	drivers/gpio/gpio-omap.c:523 omap_gpio_irq_type()
	warn: inconsistent returns 'spin_lock:&bank->lock'.

This fixes commit:
1562e461 ('gpio: omap: fix error handling in omap_gpio_irq_type')

Reported-by: Javier Martinez Canillas <javier@dowhile0.org>
Signed-off-by: Grygorii Strashko <grygorii.strashko@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 2252607d

drivers/gpio/gpio-omap.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -500,8 +500,10 @@ static int omap_gpio_irq_type(struct irq_data *d, unsigned type)

		spin_lock_irqsave(&bank->lock, flags);
		retval = omap_set_gpio_triggering(bank, offset, type);
		if (retval)
		if (retval) {
		spin_unlock_irqrestore(&bank->lock, flags);
		goto error;
		}
		omap_gpio_init_irq(bank, offset);
		if (!omap_gpio_is_input(bank, offset)) {
		spin_unlock_irqrestore(&bank->lock, flags);

Admin message