Commit 97784615 authored Dec 12, 2017 by Jia-Ju Bai Committed by Greg Kroah-Hartman Dec 18, 2017

vme: Fix a possible sleep-in-atomic bug in vme_tsi148



The driver may sleep under a spinlock.
The function call path is:
tsi148_master_write \ tsi148_master_read (acquire the spinlock)
  vme_register_error_handler
    kmalloc(GFP_KERNEL) --> may sleep

To fix it, GFP_KERNEL is replaced with GFP_ATOMIC.

This bug is found by my static analysis tool(DSAC) and checked by my code review.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent de2ee48c

drivers/vme/vme.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1290,7 +1290,7 @@ struct vme_error_handler *vme_register_error_handler(
		{
		struct vme_error_handler *handler;

		handler = kmalloc(sizeof(*handler), GFP_KERNEL);
		handler = kmalloc(sizeof(*handler), GFP_ATOMIC);
		if (!handler)
		return NULL;

Admin message