f2fs: update i_size when __allocate_data_block (976e4c50) · Commits · 戴 / test

The f2fs_direct_IO uses __allocate_data_block, but inside the allocation path, we should update i_size at the changed time to update its inode page. Otherwise, we can get wrong i_size after roll-forward recovery. Signed-off-by:

Jaegeuk Kim <jaegeuk@kernel.org>

fs/f2fs/data.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -572,9 +572,11 @@ put_err:
		static int __allocate_data_block(struct dnode_of_data *dn)
		{
		struct f2fs_sb_info *sbi = F2FS_I_SB(dn->inode);
		struct f2fs_inode_info *fi = F2FS_I(dn->inode);
		struct f2fs_summary sum;
		block_t new_blkaddr;
		struct node_info ni;
		pgoff_t fofs;
		int type;

		if (unlikely(is_inode_flag_set(F2FS_I(dn->inode), FI_NO_ALLOC)))
		@@ -597,6 +599,12 @@ static int __allocate_data_block(struct dnode_of_data *dn)
		update_extent_cache(new_blkaddr, dn);
		clear_inode_flag(F2FS_I(dn->inode), FI_NO_EXTENT);

		/* update i_size */
		fofs = start_bidx_of_node(ofs_of_node(dn->node_page), fi) +
		dn->ofs_in_node;
		if (i_size_read(dn->inode) < ((fofs + 1) << PAGE_CACHE_SHIFT))
		i_size_write(dn->inode, ((fofs + 1) << PAGE_CACHE_SHIFT));

		dn->data_blkaddr = new_blkaddr;
		return 0;
		}

Admin message