Commit 974709bd authored Jun 16, 2009 by Mel Gorman Committed by Linus Torvalds Jun 16, 2009

page allocator: get the pageblock migratetype without disabling interrupts



Local interrupts are disabled when freeing pages to the PCP list.  Part of
that free checks what the migratetype of the pageblock the page is in but
it checks this with interrupts disabled and interupts should never be
disabled longer than necessary.  This patch checks the pagetype with
interrupts enabled with the impact that it is possible a page is freed to
the wrong list when a pageblock changes type.  As that block is now
already considered mixed from an anti-fragmentation perspective, it's not
of vital importance.

Signed-off-by: Mel Gorman <mel@csn.ul.ie>
Cc: Christoph Lameter <cl@linux-foundation.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent f2260e6b

mm/page_alloc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1030,6 +1030,7 @@ static void free_hot_cold_page(struct page *page, int cold)
		kernel_map_pages(page, 1, 0);

		pcp = &zone_pcp(zone, get_cpu())->pcp;
		set_page_private(page, get_pageblock_migratetype(page));
		local_irq_save(flags);
		if (unlikely(clearMlocked))
		free_page_mlock(page);
		@@ -1039,7 +1040,6 @@ static void free_hot_cold_page(struct page *page, int cold)
		list_add_tail(&page->lru, &pcp->list);
		else
		list_add(&page->lru, &pcp->list);
		set_page_private(page, get_pageblock_migratetype(page));
		pcp->count++;
		if (pcp->count >= pcp->high) {
		free_pages_bulk(zone, pcp->batch, &pcp->list, 0);

Admin message