Commit 972fae69 authored Apr 15, 2015 by Aaron Tomlin Committed by Linus Torvalds Apr 15, 2015

kernel/hung_task.c: change hung_task.c to use for_each_process_thread()



In check_hung_uninterruptible_tasks() avoid the use of deprecated
while_each_thread().

The "max_count" logic will prevent a livelock - see commit 0c740d0a
("introduce for_each_thread() to replace the buggy while_each_thread()").
Having said this let's use for_each_process_thread().

Signed-off-by: Aaron Tomlin <atomlin@redhat.com>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Dave Wysochanski <dwysocha@redhat.com>
Cc: Aaron Tomlin <atomlin@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 96831c0a

kernel/hung_task.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -169,7 +169,7 @@ static void check_hung_uninterruptible_tasks(unsigned long timeout)
		return;

		rcu_read_lock();
		do_each_thread(g, t) {
		for_each_process_thread(g, t) {
		if (!max_count--)
		goto unlock;
		if (!--batch_count) {
		@@ -180,7 +180,7 @@ static void check_hung_uninterruptible_tasks(unsigned long timeout)
		/* use "==" to skip the TASK_KILLABLE tasks waiting on NFS */
		if (t->state == TASK_UNINTERRUPTIBLE)
		check_hung_task(t, timeout);
		} while_each_thread(g, t);
		}
		unlock:
		rcu_read_unlock();
		}

Admin message