Commit 972fa1c5 authored Aug 22, 2010 by Namhyung Kim Committed by Tejun Heo Aug 23, 2010

workqueue: mark lock acquisition on worker_maybe_bind_and_lock()

worker_maybe_bind_and_lock() actually grabs gcwq->lock but was missing proper
annotation. Add it. So this patch will remove following sparse warnings:

kernel/workqueue.c:1214:13: warning: context imbalance in 'worker_maybe_bind_and_lock' - wrong count at exit
arch/x86/include/asm/irqflags.h:44:9: warning: context imbalance in 'worker_rebind_fn' - unexpected unlock
kernel/workqueue.c:1991:17: warning: context imbalance in 'rescuer_thread' - unexpected unlock

Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>

parent 06bd6ebf

kernel/workqueue.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1212,6 +1212,7 @@ static void worker_leave_idle(struct worker *worker)
		* bound), %false if offline.
		*/
		static bool worker_maybe_bind_and_lock(struct worker *worker)
		__acquires(&gcwq->lock)
		{
		struct global_cwq *gcwq = worker->gcwq;
		struct task_struct *task = worker->task;

Admin message