Commit 9728e5d6 authored Mar 05, 2010 by Tetsuo Handa Committed by Linus Torvalds Mar 06, 2010

kernel/pid.c: update comment on find_task_by_pid_ns



tasklist_lock does protect the task and its pid, it can't go away.  The
problem is that find_pid_ns() itself is unsafe without rcu lock, it can
race with copy_process()->free_pid(any_pid).

Protecting copy_process()->free_pid(any_pid) with tasklist_lock would make
it possible to call find_task_by_pid_ns() under tasklist safely, but we
don't do so because we are trying to get rid of the read_lock sites of
tasklist_lock.

Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: "Paul E. McKenney" <paulmck@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 8aeee85a

kernel/pid.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -376,7 +376,7 @@ struct task_struct pid_task(struct pid pid, enum pid_type type)
		EXPORT_SYMBOL(pid_task);

		/*
		* Must be called under rcu_read_lock() or with tasklist_lock read-held.
		* Must be called under rcu_read_lock().
		*/
		struct task_struct find_task_by_pid_ns(pid_t nr, struct pid_namespace ns)
		{

Admin message