Commit 971f2abb authored May 08, 2020 by Benjamin Block Committed by Martin K. Petersen May 11, 2020

scsi: zfcp: Fence adapter status propagation for common statuses

Common status flags that all main objects - adapter, port, and unit -
support are propagated to sub-objects when set or cleared. For instance,
when setting the status ZFCP_STATUS_COMMON_ERP_INUSE for an adapter object,
we will propagate this to all its child ports and units - same for when
clearing a common status flag.

Units of an adapter object are enumerated via __shost_for_each_device()
over the scsi host object of the corresponding adapter.

Once we move the scsi host object allocation and registration to after the
first exchange config and exchange port data, this won't be possible for
cases where we set or clear common statuses during the very first adapter
recovery.

But since we won't have any port or unit objects yet at that point of time,
we can just fence the status propagation for cases where the scsi host
object is not yet set in the adapter object. It won't change any effective
status propagations, but will prevent us from dereferencing invalid
pointers.

For any later point in the work flow the scsi host object will be set and
thus nothing is changed then.

Link: https://lore.kernel.org/r/f51fe5f236a1e3d1ce53379c308777561bfe35e1.1588956679.git.bblock@linux.ibm.com


Reviewed-by: Steffen Maier <maier@linux.ibm.com>
Signed-off-by: Benjamin Block <bblock@linux.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent ac007adc

drivers/s390/scsi/zfcp_erp.c

+14 −0

Original line number	Diff line number	Diff line
		@@ -1642,6 +1642,13 @@ void zfcp_erp_set_adapter_status(struct zfcp_adapter *adapter, u32 mask)
		atomic_or(common_mask, &port->status);
		read_unlock_irqrestore(&adapter->port_list_lock, flags);

		/*
		* if `scsi_host` is missing, xconfig/xport data has never completed
		* yet, so we can't access it, but there are also no SDEVs yet
		*/
		if (adapter->scsi_host == NULL)
		return;

		spin_lock_irqsave(adapter->scsi_host->host_lock, flags);
		__shost_for_each_device(sdev, adapter->scsi_host)
		atomic_or(common_mask, &sdev_to_zfcp(sdev)->status);
		@@ -1679,6 +1686,13 @@ void zfcp_erp_clear_adapter_status(struct zfcp_adapter *adapter, u32 mask)
		}
		read_unlock_irqrestore(&adapter->port_list_lock, flags);

		/*
		* if `scsi_host` is missing, xconfig/xport data has never completed
		* yet, so we can't access it, but there are also no SDEVs yet
		*/
		if (adapter->scsi_host == NULL)
		return;

		spin_lock_irqsave(adapter->scsi_host->host_lock, flags);
		__shost_for_each_device(sdev, adapter->scsi_host) {
		atomic_andnot(common_mask, &sdev_to_zfcp(sdev)->status);

Admin message