ext4: fix coverity warning on error path of filename setup (96fcaf86) · Commits · 戴 / test

Fix the following coverity warning reported by Dan Carpenter: fs/ext4/namei.c:1311 ext4_fname_setup_ci_filename() warn: 'cf_name->len' unsigned <= 0 Fixes: ("ext4: optimize case-insensitive lookups") Signed-off-by:

Gabriel Krisman Bertazi <krisman@collabora.com> Signed-off-by:

Theodore Ts'o <tytso@mit.edu> Reported-by:

Dan Carpenter <dan.carpenter@oracle.com>

fs/ext4/namei.c

+9 −4

Original line number	Diff line number	Diff line
		@@ -1310,6 +1310,8 @@ int ext4_ci_compare(const struct inode parent, const struct qstr name,
		void ext4_fname_setup_ci_filename(struct inode dir, const struct qstr iname,
		struct fscrypt_str *cf_name)
		{
		int len;

		if (!IS_CASEFOLDED(dir)) {
		cf_name->name = NULL;
		return;
		@@ -1319,13 +1321,16 @@ void ext4_fname_setup_ci_filename(struct inode dir, const struct qstr iname,
		if (!cf_name->name)
		return;

		cf_name->len = utf8_casefold(EXT4_SB(dir->i_sb)->s_encoding,
		len = utf8_casefold(EXT4_SB(dir->i_sb)->s_encoding,
		iname, cf_name->name,
		EXT4_NAME_LEN);
		if (cf_name->len <= 0) {
		if (len <= 0) {
		kfree(cf_name->name);
		cf_name->name = NULL;
		return;
		}
		cf_name->len = (unsigned) len;

		}
		#endif

Admin message