Commit 96d97f26 authored May 31, 2008 by Sam Ravnborg

kbuild: fix $(src) assignmnet with external modules

When we introduced support for KBUILD_EXTRA_SYMBOLS
we started to include the externam module's kbuild
file when doing the final modpost step.

As external modules often do:
ccflags-y := -I$(src)

We had problems because $(src) was unassinged and
gcc then used the next parameter for -I resulting in
strange build failures.

Fix is to assign $(src) and $(obj) when building
external modules.

This fixes: http://bugzilla.kernel.org/show_bug.cgi?id=10798



Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Tvrtko <tvrtko.ursulin@sophos.com>
Cc: Andrea Arcangeli <andrea@qumranet.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>

parent 73531905

scripts/Makefile.modpost

+6 −0

Original line number	Diff line number	Diff line
		@@ -43,7 +43,13 @@ _modpost: __modpost
		include include/config/auto.conf
		include scripts/Kbuild.include

		# When building external modules load the Kbuild file to retreive EXTRA_SYMBOLS info
		ifneq ($(KBUILD_EXTMOD),)

		# set src + obj - they may be used when building the .mod.c file
		obj := $(KBUILD_EXTMOD)
		src := $(obj)

		# Include the module's Makefile to find KBUILD_EXTRA_SYMBOLS
		include $(if $(wildcard $(KBUILD_EXTMOD)/Kbuild), \
		$(KBUILD_EXTMOD)/Kbuild, $(KBUILD_EXTMOD)/Makefile)

Admin message