Commit 96d25e53 authored Nov 11, 2009 by Trond Myklebust

NFSv4: Fix a cache validation bug which causes getcwd() to return ENOENT

Changeset a65318bf (NFSv4: Simplify some
cache consistency post-op GETATTRs) incorrectly changed the getattr
bitmap for readdir().
This causes the readdir() function to fail to return a
fileid/inode number, which again exposed a bug in the NFS readdir code that
causes spurious ENOENT errors to appear in applications (see
http://bugzilla.kernel.org/show_bug.cgi?id=14541

).

The immediate band aid is to revert the incorrect bitmap change, but more
long term, we should change the NFS readdir code to cope with the
fact that NFSv4 servers are not required to support fileids/inode numbers.

Reported-by: Daniel J Blueman <daniel.blueman@gmail.com>
Cc: stable@kernel.org
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

parent 799dd75b

fs/nfs/nfs4proc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2767,7 +2767,7 @@ static int _nfs4_proc_readdir(struct dentry dentry, struct rpc_cred cred,
		.pages = &page,
		.pgbase = 0,
		.count = count,
		.bitmask = NFS_SERVER(dentry->d_inode)->cache_consistency_bitmask,
		.bitmask = NFS_SERVER(dentry->d_inode)->attr_bitmask,
		};
		struct nfs4_readdir_res res;
		struct rpc_message msg = {

Admin message