Commit 96be65d1 authored Feb 01, 2019 by Wei Yongjun Committed by Linus Walleij Feb 09, 2019

gpio: tqmx86: Drop unnecessary gpiochip_remove in tqmx86_gpio_probe()



It's not necessary to remove gpio_chip which added with
devm_gpiochip_add_data().

Fixes: b868db94 ("gpio: tqmx86: Add GPIO from for this IO controller")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 2a0b0a57

drivers/gpio/gpio-tqmx86.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -291,7 +291,7 @@ static int tqmx86_gpio_probe(struct platform_device *pdev)
		IRQ_TYPE_EDGE_BOTH);
		if (ret) {
		dev_err(dev, "Could not add irq chip\n");
		goto out_remove;
		goto out_pm_dis;
		}

		gpiochip_set_chained_irqchip(chip, irq_chip,
		@@ -309,8 +309,6 @@ static int tqmx86_gpio_probe(struct platform_device *pdev)

		return 0;

		out_remove:
		gpiochip_remove(&gpio->chip);
		out_pm_dis:
		pm_runtime_disable(&pdev->dev);

Admin message