Commit 96a99501 authored Sep 16, 2011 by Julia Lawall Committed by James Bottomley Sep 22, 2011

[SCSI] mpt2sas: take size of pointed value, not pointer

Sizeof a pointer-typed expression returns the size of the pointer, not that
of the pointed data.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression *e;
type T;
identifier f;
@@

f(...,(T)e,...,
-sizeof(e)
+sizeof(*e)
,...)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>

parent 12b8fc10

drivers/scsi/mpt2sas/mpt2sas_transport.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -163,7 +163,7 @@ _transport_set_identify(struct MPT2SAS_ADAPTER *ioc, u16 handle,
		return -EIO;
		}

		memset(identify, 0, sizeof(identify));
		memset(identify, 0, sizeof(*identify));
		device_info = le32_to_cpu(sas_device_pg0.DeviceInfo);

		/* sas_address */

Admin message