Unverified Commit 96a68b14 authored by Paul Burton's avatar Paul Burton
Browse files

MIPS: Remove nabi_no_regargs 



Our sigreturn functions make use of a macro named nabi_no_regargs to
declare 8 dummy arguments to a function, forcing the compiler to expect
a pt_regs structure on the stack rather than in argument registers. This
is an ugly hack which unnecessarily causes these sigreturn functions to
need to care about the calling convention of the ABI the kernel is built
for. Although this is abstracted via nabi_no_regargs, it's still ugly &
unnecessary.

Remove nabi_no_regargs & the struct pt_regs argument from sigreturn
functions, and instead use current_pt_regs() to find the struct pt_regs
on the stack, which works cleanly regardless of ABI.

Signed-off-by: default avatarPaul Burton <paul.burton@mips.com>
Patchwork: https://patchwork.linux-mips.org/patch/20106/
Cc: James Hogan <jhogan@kernel.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
parent 84a7f564

arch/mips/include/asm/sim.h

+0 −12
Original line number Diff line number Diff line
@@ -39,8 +39,6 @@ __asm__( \ 
	".end\t__" #symbol "\n\t"					\

	".size\t__" #symbol",. - __" #symbol)



#define nabi_no_regargs



#endif /* CONFIG_32BIT */



#ifdef CONFIG_64BIT
@@ -67,16 +65,6 @@ __asm__( \ 
	".end\t__" #symbol "\n\t"					\

	".size\t__" #symbol",. - __" #symbol)



#define nabi_no_regargs							\

	unsigned long __dummy0,						\

	unsigned long __dummy1,						\

	unsigned long __dummy2,						\

	unsigned long __dummy3,						\

	unsigned long __dummy4,						\

	unsigned long __dummy5,						\

	unsigned long __dummy6,						\

	unsigned long __dummy7,



#endif /* CONFIG_64BIT */



#endif /* _ASM_SIM_H */

arch/mips/kernel/signal.c

+14 −10
Original line number Diff line number Diff line
@@ -592,13 +592,15 @@ SYSCALL_DEFINE3(sigaction, int, sig, const struct sigaction __user *, act, 
#endif



#ifdef CONFIG_TRAD_SIGNALS

asmlinkage void sys_sigreturn(nabi_no_regargs struct pt_regs regs)

asmlinkage void sys_sigreturn(void)

{

	struct sigframe __user *frame;

	struct pt_regs *regs;

	sigset_t blocked;

	int sig;



	frame = (struct sigframe __user *) regs.regs[29];

	regs = current_pt_regs();

	frame = (struct sigframe __user *)regs->regs[29];

	if (!access_ok(VERIFY_READ, frame, sizeof(*frame)))

		goto badframe;

	if (__copy_from_user(&blocked, &frame->sf_mask, sizeof(blocked)))
@@ -606,7 +608,7 @@ asmlinkage void sys_sigreturn(nabi_no_regargs struct pt_regs regs) 


	set_current_blocked(&blocked);



	sig = restore_sigcontext(&regs, &frame->sf_sc);

	sig = restore_sigcontext(regs, &frame->sf_sc);

	if (sig < 0)

		goto badframe;

	else if (sig)
@@ -619,7 +621,7 @@ asmlinkage void sys_sigreturn(nabi_no_regargs struct pt_regs regs) 
		"move\t$29, %0\n\t"

		"j\tsyscall_exit"

		: /* no outputs */

		:"r" (&regs));

		: "r" (regs));

	/* Unreached */



badframe:
@@ -627,13 +629,15 @@ badframe: 
}

#endif /* CONFIG_TRAD_SIGNALS */



asmlinkage void sys_rt_sigreturn(nabi_no_regargs struct pt_regs regs)

asmlinkage void sys_rt_sigreturn(void)

{

	struct rt_sigframe __user *frame;

	struct pt_regs *regs;

	sigset_t set;

	int sig;



	frame = (struct rt_sigframe __user *) regs.regs[29];

	regs = current_pt_regs();

	frame = (struct rt_sigframe __user *)regs->regs[29];

	if (!access_ok(VERIFY_READ, frame, sizeof(*frame)))

		goto badframe;

	if (__copy_from_user(&set, &frame->rs_uc.uc_sigmask, sizeof(set)))
@@ -641,7 +645,7 @@ asmlinkage void sys_rt_sigreturn(nabi_no_regargs struct pt_regs regs) 


	set_current_blocked(&set);



	sig = restore_sigcontext(&regs, &frame->rs_uc.uc_mcontext);

	sig = restore_sigcontext(regs, &frame->rs_uc.uc_mcontext);

	if (sig < 0)

		goto badframe;

	else if (sig)
@@ -657,7 +661,7 @@ asmlinkage void sys_rt_sigreturn(nabi_no_regargs struct pt_regs regs) 
		"move\t$29, %0\n\t"

		"j\tsyscall_exit"

		: /* no outputs */

		:"r" (&regs));

		: "r" (regs));

	/* Unreached */



badframe:

arch/mips/kernel/signal_n32.c

+7 −5
Original line number Diff line number Diff line
@@ -64,13 +64,15 @@ struct rt_sigframe_n32 { 
	struct ucontextn32 rs_uc;

};



asmlinkage void sysn32_rt_sigreturn(nabi_no_regargs struct pt_regs regs)

asmlinkage void sysn32_rt_sigreturn(void)

{

	struct rt_sigframe_n32 __user *frame;

	struct pt_regs *regs;

	sigset_t set;

	int sig;



	frame = (struct rt_sigframe_n32 __user *) regs.regs[29];

	regs = current_pt_regs();

	frame = (struct rt_sigframe_n32 __user *)regs->regs[29];

	if (!access_ok(VERIFY_READ, frame, sizeof(*frame)))

		goto badframe;

	if (__copy_conv_sigset_from_user(&set, &frame->rs_uc.uc_sigmask))
@@ -78,7 +80,7 @@ asmlinkage void sysn32_rt_sigreturn(nabi_no_regargs struct pt_regs regs) 


	set_current_blocked(&set);



	sig = restore_sigcontext(&regs, &frame->rs_uc.uc_mcontext);

	sig = restore_sigcontext(regs, &frame->rs_uc.uc_mcontext);

	if (sig < 0)

		goto badframe;

	else if (sig)
@@ -94,7 +96,7 @@ asmlinkage void sysn32_rt_sigreturn(nabi_no_regargs struct pt_regs regs) 
		"move\t$29, %0\n\t"

		"j\tsyscall_exit"

		: /* no outputs */

		:"r" (&regs));

		: "r" (regs));

	/* Unreached */



badframe:

arch/mips/kernel/signal_o32.c

+14 −10
Original line number Diff line number Diff line
@@ -151,13 +151,15 @@ static int setup_frame_32(void *sig_return, struct ksignal *ksig, 
	return 0;

}



asmlinkage void sys32_rt_sigreturn(nabi_no_regargs struct pt_regs regs)

asmlinkage void sys32_rt_sigreturn(void)

{

	struct rt_sigframe32 __user *frame;

	struct pt_regs *regs;

	sigset_t set;

	int sig;



	frame = (struct rt_sigframe32 __user *) regs.regs[29];

	regs = current_pt_regs();

	frame = (struct rt_sigframe32 __user *)regs->regs[29];

	if (!access_ok(VERIFY_READ, frame, sizeof(*frame)))

		goto badframe;

	if (__copy_conv_sigset_from_user(&set, &frame->rs_uc.uc_sigmask))
@@ -165,7 +167,7 @@ asmlinkage void sys32_rt_sigreturn(nabi_no_regargs struct pt_regs regs) 


	set_current_blocked(&set);



	sig = restore_sigcontext32(&regs, &frame->rs_uc.uc_mcontext);

	sig = restore_sigcontext32(regs, &frame->rs_uc.uc_mcontext);

	if (sig < 0)

		goto badframe;

	else if (sig)
@@ -181,7 +183,7 @@ asmlinkage void sys32_rt_sigreturn(nabi_no_regargs struct pt_regs regs) 
		"move\t$29, %0\n\t"

		"j\tsyscall_exit"

		: /* no outputs */

		:"r" (&regs));

		: "r" (regs));

	/* Unreached */



badframe:
@@ -251,13 +253,15 @@ struct mips_abi mips_abi_32 = { 
};





asmlinkage void sys32_sigreturn(nabi_no_regargs struct pt_regs regs)

asmlinkage void sys32_sigreturn(void)

{

	struct sigframe32 __user *frame;

	struct pt_regs *regs;

	sigset_t blocked;

	int sig;



	frame = (struct sigframe32 __user *) regs.regs[29];

	regs = current_pt_regs();

	frame = (struct sigframe32 __user *)regs->regs[29];

	if (!access_ok(VERIFY_READ, frame, sizeof(*frame)))

		goto badframe;

	if (__copy_conv_sigset_from_user(&blocked, &frame->sf_mask))
@@ -265,7 +269,7 @@ asmlinkage void sys32_sigreturn(nabi_no_regargs struct pt_regs regs) 


	set_current_blocked(&blocked);



	sig = restore_sigcontext32(&regs, &frame->sf_sc);

	sig = restore_sigcontext32(regs, &frame->sf_sc);

	if (sig < 0)

		goto badframe;

	else if (sig)
@@ -278,7 +282,7 @@ asmlinkage void sys32_sigreturn(nabi_no_regargs struct pt_regs regs) 
		"move\t$29, %0\n\t"

		"j\tsyscall_exit"

		: /* no outputs */

		:"r" (&regs));

		: "r" (regs));

	/* Unreached */



badframe:

CRA Git | Maintained and supported by SUSTech CRA and CCSE