Commit 96a5aa72 authored May 01, 2020 by Eric Biggers Committed by Herbert Xu May 08, 2020

nfc: s3fwrn5: use crypto_shash_tfm_digest()

Instead of manually allocating a 'struct shash_desc' on the stack and
calling crypto_shash_digest(), switch to using the new helper function
crypto_shash_tfm_digest() which does this for us.

Cc: Robert Baldyga <r.baldyga@samsung.com>
Cc: Krzysztof Opasiak <k.opasiak@samsung.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent ecca1ad6

drivers/nfc/s3fwrn5/firmware.c

+1 −9

Original line number	Diff line number	Diff line
		@@ -434,15 +434,7 @@ int s3fwrn5_fw_download(struct s3fwrn5_fw_info *fw_info)
		goto out;
		}

		{
		SHASH_DESC_ON_STACK(desc, tfm);

		desc->tfm = tfm;

		ret = crypto_shash_digest(desc, fw->image, image_size,
		hash_data);
		shash_desc_zero(desc);
		}
		ret = crypto_shash_tfm_digest(tfm, fw->image, image_size, hash_data);

		crypto_free_shash(tfm);
		if (ret) {

Admin message