Commit 966291f6 authored by Ard Biesheuvel's avatar Ard Biesheuvel Committed by Ingo Molnar
Browse files

efi/libstub: Rename efi_call_early/_runtime macros to be more intuitive 



The macros efi_call_early and efi_call_runtime are used to call EFI
boot services and runtime services, respectively. However, the naming
is confusing, given that the early vs runtime distinction may suggest
that these are used for calling the same set of services either early
or late (== at runtime), while in reality, the sets of services they
can be used with are completely disjoint, and efi_call_runtime is also
only usable in 'early' code.

So do a global sweep to replace all occurrences with efi_bs_call or
efi_rt_call, respectively, where BS and RT match the idiom used by
the UEFI spec to refer to boot time or runtime services.

While at it, use 'func' as the macro parameter name for the function
pointers, which is less likely to collide and cause weird build errors.

Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
Cc: Arvind Sankar <nivedita@alum.mit.edu>
Cc: Borislav Petkov <bp@alien8.de>
Cc: James Morse <james.morse@arm.com>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-efi@vger.kernel.org
Link: https://lkml.kernel.org/r/20191224151025.32482-24-ardb@kernel.org


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 99ea8b1d

arch/arm/include/asm/efi.h

+3 −3
Original line number Diff line number Diff line
@@ -50,8 +50,8 @@ void efi_virtmap_unload(void); 


/* arch specific definitions used by the stub code */



#define efi_call_early(f, ...)		efi_system_table()->boottime->f(__VA_ARGS__)

#define efi_call_runtime(f, ...)	efi_system_table()->runtime->f(__VA_ARGS__)

#define efi_bs_call(func, ...)	efi_system_table()->boottime->func(__VA_ARGS__)

#define efi_rt_call(func, ...)	efi_system_table()->runtime->func(__VA_ARGS__)

#define efi_is_native()		(true)



#define efi_table_attr(inst, attr)	(inst->attr)

arch/arm64/include/asm/efi.h

+3 −3
Original line number Diff line number Diff line
@@ -93,8 +93,8 @@ static inline unsigned long efi_get_max_initrd_addr(unsigned long dram_base, 
	return (image_addr & ~(SZ_1G - 1UL)) + (1UL << (VA_BITS_MIN - 1));

}



#define efi_call_early(f, ...)		efi_system_table()->boottime->f(__VA_ARGS__)

#define efi_call_runtime(f, ...)	efi_system_table()->runtime->f(__VA_ARGS__)

#define efi_bs_call(func, ...)	efi_system_table()->boottime->func(__VA_ARGS__)

#define efi_rt_call(func, ...)	efi_system_table()->runtime->func(__VA_ARGS__)

#define efi_is_native()		(true)



#define efi_table_attr(inst, attr)	(inst->attr)

arch/x86/boot/compressed/eboot.c

+35 −42
Original line number Diff line number Diff line
@@ -54,7 +54,7 @@ preserve_pci_rom_image(efi_pci_io_protocol_t *pci, struct pci_setup_rom **__rom) 


	size = romsize + sizeof(*rom);



	status = efi_call_early(allocate_pool, EFI_LOADER_DATA, size,

	status = efi_bs_call(allocate_pool, EFI_LOADER_DATA, size,

			     (void **)&rom);

	if (status != EFI_SUCCESS) {

		efi_printk("Failed to allocate memory for 'rom'\n");
@@ -95,7 +95,7 @@ preserve_pci_rom_image(efi_pci_io_protocol_t *pci, struct pci_setup_rom **__rom) 
	return status;



free_struct:

	efi_call_early(free_pool, rom);

	efi_bs_call(free_pool, rom);

	return status;

}
@@ -119,23 +119,20 @@ static void setup_efi_pci(struct boot_params *params) 
	efi_handle_t h;

	int i;



	status = efi_call_early(locate_handle,

				EFI_LOCATE_BY_PROTOCOL,

	status = efi_bs_call(locate_handle, EFI_LOCATE_BY_PROTOCOL,

			     &pci_proto, NULL, &size, pci_handle);



	if (status == EFI_BUFFER_TOO_SMALL) {

		status = efi_call_early(allocate_pool,

					EFI_LOADER_DATA,

					size, (void **)&pci_handle);

		status = efi_bs_call(allocate_pool, EFI_LOADER_DATA, size,

				     (void **)&pci_handle);



		if (status != EFI_SUCCESS) {

			efi_printk("Failed to allocate memory for 'pci_handle'\n");

			return;

		}



		status = efi_call_early(locate_handle,

					EFI_LOCATE_BY_PROTOCOL, &pci_proto,

					NULL, &size, pci_handle);

		status = efi_bs_call(locate_handle, EFI_LOCATE_BY_PROTOCOL,

				     &pci_proto, NULL, &size, pci_handle);

	}



	if (status != EFI_SUCCESS)
@@ -150,8 +147,8 @@ static void setup_efi_pci(struct boot_params *params) 
		efi_pci_io_protocol_t *pci = NULL;

		struct pci_setup_rom *rom;



		status = efi_call_early(handle_protocol, h,

					&pci_proto, (void **)&pci);

		status = efi_bs_call(handle_protocol, h, &pci_proto,

				     (void **)&pci);

		if (status != EFI_SUCCESS || !pci)

			continue;
@@ -168,7 +165,7 @@ static void setup_efi_pci(struct boot_params *params) 
	}



free_handle:

	efi_call_early(free_pool, pci_handle);

	efi_bs_call(free_pool, pci_handle);

}



static void retrieve_apple_device_properties(struct boot_params *boot_params)
@@ -179,7 +176,7 @@ static void retrieve_apple_device_properties(struct boot_params *boot_params) 
	u32 size = 0;

	apple_properties_protocol_t *p;



	status = efi_call_early(locate_protocol, &guid, NULL, (void **)&p);

	status = efi_bs_call(locate_protocol, &guid, NULL, (void **)&p);

	if (status != EFI_SUCCESS)

		return;
@@ -193,7 +190,7 @@ static void retrieve_apple_device_properties(struct boot_params *boot_params) 
		return;



	do {

		status = efi_call_early(allocate_pool, EFI_LOADER_DATA,

		status = efi_bs_call(allocate_pool, EFI_LOADER_DATA,

				     size + sizeof(struct setup_data),

				     (void **)&new);

		if (status != EFI_SUCCESS) {
@@ -204,7 +201,7 @@ static void retrieve_apple_device_properties(struct boot_params *boot_params) 
		status = efi_call_proto(p, get_all, new->data, &size);



		if (status == EFI_BUFFER_TOO_SMALL)

			efi_call_early(free_pool, new);

			efi_bs_call(free_pool, new);

	} while (status == EFI_BUFFER_TOO_SMALL);



	new->type = SETUP_APPLE_PROPERTIES;
@@ -248,13 +245,12 @@ setup_uga(struct screen_info *si, efi_guid_t *uga_proto, unsigned long size) 
	efi_handle_t handle;

	int i;



	status = efi_call_early(allocate_pool, EFI_LOADER_DATA,

				size, (void **)&uga_handle);

	status = efi_bs_call(allocate_pool, EFI_LOADER_DATA, size,

			     (void **)&uga_handle);

	if (status != EFI_SUCCESS)

		return status;



	status = efi_call_early(locate_handle,

				EFI_LOCATE_BY_PROTOCOL,

	status = efi_bs_call(locate_handle, EFI_LOCATE_BY_PROTOCOL,

			     uga_proto, NULL, &size, uga_handle);

	if (status != EFI_SUCCESS)

		goto free_handle;
@@ -268,13 +264,13 @@ setup_uga(struct screen_info *si, efi_guid_t *uga_proto, unsigned long size) 
		u32 w, h, depth, refresh;

		void *pciio;



		status = efi_call_early(handle_protocol, handle,

					uga_proto, (void **)&uga);

		status = efi_bs_call(handle_protocol, handle, uga_proto,

				     (void **)&uga);

		if (status != EFI_SUCCESS)

			continue;



		pciio = NULL;

		efi_call_early(handle_protocol, handle, &pciio_proto, &pciio);

		efi_bs_call(handle_protocol, handle, &pciio_proto, &pciio);



		status = efi_call_proto(uga, get_mode, &w, &h, &depth, &refresh);

		if (status == EFI_SUCCESS && (!first_uga || pciio)) {
@@ -312,7 +308,7 @@ setup_uga(struct screen_info *si, efi_guid_t *uga_proto, unsigned long size) 
	si->rsvd_pos		= 24;



free_handle:

	efi_call_early(free_pool, uga_handle);

	efi_bs_call(free_pool, uga_handle);



	return status;

}
@@ -331,16 +327,14 @@ void setup_graphics(struct boot_params *boot_params) 
	memset(si, 0, sizeof(*si));



	size = 0;

	status = efi_call_early(locate_handle,

				EFI_LOCATE_BY_PROTOCOL,

	status = efi_bs_call(locate_handle, EFI_LOCATE_BY_PROTOCOL,

			     &graphics_proto, NULL, &size, gop_handle);

	if (status == EFI_BUFFER_TOO_SMALL)

		status = efi_setup_gop(si, &graphics_proto, size);



	if (status != EFI_SUCCESS) {

		size = 0;

		status = efi_call_early(locate_handle,

					EFI_LOCATE_BY_PROTOCOL,

		status = efi_bs_call(locate_handle, EFI_LOCATE_BY_PROTOCOL,

				     &uga_proto, NULL, &size, uga_handle);

		if (status == EFI_BUFFER_TOO_SMALL)

			setup_uga(si, &uga_proto, size);
@@ -378,8 +372,7 @@ efi_status_t __efiapi efi_pe_entry(efi_handle_t handle, 
	if (sys_table->hdr.signature != EFI_SYSTEM_TABLE_SIGNATURE)

		return EFI_INVALID_PARAMETER;



	status = efi_call_early(handle_protocol, handle,

				&proto, (void *)&image);

	status = efi_bs_call(handle_protocol, handle, &proto, (void *)&image);

	if (status != EFI_SUCCESS) {

		efi_printk("Failed to get handle for LOADED_IMAGE_PROTOCOL\n");

		return status;
@@ -594,13 +587,13 @@ static efi_status_t alloc_e820ext(u32 nr_desc, struct setup_data **e820ext, 
		sizeof(struct e820_entry) * nr_desc;



	if (*e820ext) {

		efi_call_early(free_pool, *e820ext);

		efi_bs_call(free_pool, *e820ext);

		*e820ext = NULL;

		*e820ext_size = 0;

	}



	status = efi_call_early(allocate_pool, EFI_LOADER_DATA,

				size, (void **)e820ext);

	status = efi_bs_call(allocate_pool, EFI_LOADER_DATA, size,

			     (void **)e820ext);

	if (status == EFI_SUCCESS)

		*e820ext_size = size;
@@ -762,8 +755,8 @@ struct boot_params *efi_main(efi_handle_t handle, 


	setup_quirks(boot_params);



	status = efi_call_early(allocate_pool, EFI_LOADER_DATA,

				sizeof(*gdt), (void **)&gdt);

	status = efi_bs_call(allocate_pool, EFI_LOADER_DATA, sizeof(*gdt),

			     (void **)&gdt);

	if (status != EFI_SUCCESS) {

		efi_printk("Failed to allocate memory for 'gdt' structure\n");

		goto fail;

arch/x86/include/asm/efi.h

+6 −6
Original line number Diff line number Diff line
@@ -227,17 +227,17 @@ static inline bool efi_is_native(void) 
		? inst->func(inst, ##__VA_ARGS__)			\

		: efi64_thunk(inst->mixed_mode.func, inst, ##__VA_ARGS__))



#define efi_call_early(f, ...)						\

#define efi_bs_call(func, ...)						\

	(efi_is_native()						\

		? efi_system_table()->boottime->f(__VA_ARGS__)		\

		? efi_system_table()->boottime->func(__VA_ARGS__)	\

		: efi64_thunk(efi_table_attr(efi_system_table(),	\

				boottime)->mixed_mode.f, __VA_ARGS__))

				boottime)->mixed_mode.func, __VA_ARGS__))



#define efi_call_runtime(f, ...)					\

#define efi_rt_call(func, ...)						\

	(efi_is_native()						\

		? efi_system_table()->runtime->f(__VA_ARGS__)		\

		? efi_system_table()->runtime->func(__VA_ARGS__)	\

		: efi64_thunk(efi_table_attr(efi_system_table(),	\

				runtime)->mixed_mode.f, __VA_ARGS__))

				runtime)->mixed_mode.func, __VA_ARGS__))



extern bool efi_reboot_required(void);

extern bool efi_is_table_address(unsigned long phys_addr);

drivers/firmware/efi/libstub/arm-stub.c

+6 −7
Original line number Diff line number Diff line
@@ -53,7 +53,7 @@ static struct screen_info *setup_graphics(void) 
	struct screen_info *si = NULL;



	size = 0;

	status = efi_call_early(locate_handle, EFI_LOCATE_BY_PROTOCOL,

	status = efi_bs_call(locate_handle, EFI_LOCATE_BY_PROTOCOL,

			     &gop_proto, NULL, &size, gop_handle);

	if (status == EFI_BUFFER_TOO_SMALL) {

		si = alloc_screen_info();
@@ -70,7 +70,7 @@ void install_memreserve_table(void) 
	efi_guid_t memreserve_table_guid = LINUX_EFI_MEMRESERVE_TABLE_GUID;

	efi_status_t status;



	status = efi_call_early(allocate_pool, EFI_LOADER_DATA, sizeof(*rsv),

	status = efi_bs_call(allocate_pool, EFI_LOADER_DATA, sizeof(*rsv),

			     (void **)&rsv);

	if (status != EFI_SUCCESS) {

		pr_efi_err("Failed to allocate memreserve entry!\n");
@@ -81,9 +81,8 @@ void install_memreserve_table(void) 
	rsv->size = 0;

	atomic_set(&rsv->count, 0);



	status = efi_call_early(install_configuration_table,

				&memreserve_table_guid,

				rsv);

	status = efi_bs_call(install_configuration_table,

			     &memreserve_table_guid, rsv);

	if (status != EFI_SUCCESS)

		pr_efi_err("Failed to install memreserve config table!\n");

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE