Commit 9644e6b9 authored by Hans de Goede's avatar Hans de Goede Committed by Marcel Holtmann
Browse files

Bluetooth: hci_bcm: Remove duplication in gpio-mappings declaration 



We declare the same set of const acpi_gpio_params twice with different
names, besides the needless duplication this naming leads to a sortof
double indirection which also makes it harder to see how the mapping is
actually setup.

This commit renames the first set to have generic names, which better
describe the contents of the mapping and drops the second set.

Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 4063cafa

drivers/bluetooth/hci_bcm.c

+9 −13
Original line number Diff line number Diff line
@@ -774,25 +774,21 @@ unlock: 
}

#endif



static const struct acpi_gpio_params int_last_device_wakeup_gpios = { 0, 0, false };

static const struct acpi_gpio_params int_last_shutdown_gpios = { 1, 0, false };

static const struct acpi_gpio_params int_last_host_wakeup_gpios = { 2, 0, false };

static const struct acpi_gpio_params first_gpio = { 0, 0, false };

static const struct acpi_gpio_params second_gpio = { 1, 0, false };

static const struct acpi_gpio_params third_gpio = { 2, 0, false };



static const struct acpi_gpio_mapping acpi_bcm_int_last_gpios[] = {

	{ "device-wakeup-gpios", &int_last_device_wakeup_gpios, 1 },

	{ "shutdown-gpios", &int_last_shutdown_gpios, 1 },

	{ "host-wakeup-gpios", &int_last_host_wakeup_gpios, 1 },

	{ "device-wakeup-gpios", &first_gpio, 1 },

	{ "shutdown-gpios", &second_gpio, 1 },

	{ "host-wakeup-gpios", &third_gpio, 1 },

	{ },

};



static const struct acpi_gpio_params int_first_host_wakeup_gpios = { 0, 0, false };

static const struct acpi_gpio_params int_first_device_wakeup_gpios = { 1, 0, false };

static const struct acpi_gpio_params int_first_shutdown_gpios = { 2, 0, false };



static const struct acpi_gpio_mapping acpi_bcm_int_first_gpios[] = {

	{ "device-wakeup-gpios", &int_first_device_wakeup_gpios, 1 },

	{ "shutdown-gpios", &int_first_shutdown_gpios, 1 },

	{ "host-wakeup-gpios", &int_first_host_wakeup_gpios, 1 },

	{ "host-wakeup-gpios", &first_gpio, 1 },

	{ "device-wakeup-gpios", &second_gpio, 1 },

	{ "shutdown-gpios", &third_gpio, 1 },

	{ },

};

CRA Git | Maintained and supported by SUSTech CRA and CCSE