Commit 9644302e authored by Steven Rostedt's avatar Steven Rostedt Committed by Steven Rostedt
Browse files

ftrace: Speed up search by skipping pages by address 



As all records in a page of the ftrace table are sorted, we can
speed up the search algorithm by checking if the address to look for
falls in between the first and last record ip on the page.

This speeds up both the ftrace_location() and ftrace_text_reserved()
algorithms, as it can skip full pages when the search address is
not in them.

Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
parent 706c81f8

kernel/trace/ftrace.c

+16 −6
Original line number Diff line number Diff line
@@ -1411,6 +1411,8 @@ int ftrace_location(unsigned long ip) 
	key.ip = ip;



	for (pg = ftrace_pages_start; pg; pg = pg->next) {

		if (ip < pg->records[0].ip || ip > pg->records[pg->index - 1].ip)

			continue;

		rec = bsearch(&key, pg->records, pg->index,

			      sizeof(struct dyn_ftrace),

			      ftrace_cmp_recs);
@@ -1571,16 +1573,24 @@ void ftrace_bug(int failed, unsigned long ip) 




/* Return 1 if the address range is reserved for ftrace */

int ftrace_text_reserved(void *start, void *end)

int ftrace_text_reserved(void *s, void *e)

{

	struct dyn_ftrace *rec;

	struct ftrace_page *pg;

	unsigned long start = (unsigned long)s;

	unsigned long end = (unsigned long)e;

	int i;



	do_for_each_ftrace_rec(pg, rec) {

		if (rec->ip <= (unsigned long)end &&

		    rec->ip + MCOUNT_INSN_SIZE > (unsigned long)start)

	for (pg = ftrace_pages_start; pg; pg = pg->next) {

		if (end < pg->records[0].ip ||

		    start >= (pg->records[pg->index - 1].ip + MCOUNT_INSN_SIZE))

			continue;

		for (i = 0; i < pg->index; i++) {

			rec = &pg->records[i];

			if (rec->ip <= end && rec->ip + MCOUNT_INSN_SIZE > start)

				return 1;

	} while_for_each_ftrace_rec();

		}

	}

	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE