Commit 961d1935 authored Oct 03, 2018 by Nathan Chancellor Committed by Greg Kroah-Hartman Oct 09, 2018

staging: rtl8723bs: Remove unnecessary parentheses and dead commented code

Clang warns when multiple pairs of parentheses are used for a single
conditional statement.

drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:3351:20: warning:
equality comparison with extraneous parentheses [-Wparentheses-equality]

The commented code is pointless since _HW_STATE_AP_ is handled right
below this block.

Link: https://github.com/ClangBuiltLinux/linux/issues/168


Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent ecfbc770

drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3348,7 +3348,7 @@ static void hw_var_set_opmode(struct adapter padapter, u8 variable, u8 val)
		/* disable atim wnd */
		rtw_write8(padapter, REG_BCN_CTRL, DIS_TSF_UDT\|EN_BCN_FUNCTION\|DIS_ATIM);
		/* rtw_write8(padapter, REG_BCN_CTRL, 0x18); */
		} else if ((mode == _HW_STATE_ADHOC_) /\|\| (mode == _HW_STATE_AP_)/) {
		} else if (mode == _HW_STATE_ADHOC_) {
		ResumeTxBeacon(padapter);
		rtw_write8(padapter, REG_BCN_CTRL, DIS_TSF_UDT\|EN_BCN_FUNCTION\|DIS_BCNQ_SUB);
		} else if (mode == _HW_STATE_AP_) {

Admin message