Commit 960cc0f4 authored Oct 26, 2009 by Neil Brown Committed by Jens Axboe Oct 26, 2009

block: use after free bug in __blkdev_get



commit 0762b8bd
(from 14 months ago) introduced a use-after-free bug which has just
recently started manifesting in my md testing.
I tried git bisect to find out what caused the bug to start
manifesting, and it could have been the recent change to
blk_unregister_queue (48c0d4d4) but the results were inconclusive.

This patch certainly fixes my symptoms and looks correct as the two
calls are now in the same order as elsewhere in that function.

Signed-off-by: NeilBrown <neilb@suse.de>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>

parent 6cafb12d

fs/block_dev.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1248,8 +1248,8 @@ static int __blkdev_get(struct block_device *bdev, fmode_t mode, int for_part)
		bd_set_size(bdev, (loff_t)bdev->bd_part->nr_sects << 9);
		}
		} else {
		put_disk(disk);
		module_put(disk->fops->owner);
		put_disk(disk);
		disk = NULL;
		if (bdev->bd_contains == bdev) {
		if (bdev->bd_disk->fops->open) {

Admin message