Commit 96098df1 authored Jan 07, 2016 by Julien Grossholtz Committed by Linus Walleij Jan 13, 2016

gpiolib: fix chip order in gpio list



In some situations the gpio_list order is not correct.
As a consequence gpiochip_find_base returns the same
base number twice. This happens when a first ship is added
with manual base number, then other ships are added using
automatic base number.

To prevent this behaviour, this patch add the new chip after
the last element of the gpio list.

Signed-off-by: Julien Grossholtz <julien.grossholtz@savoirfairelinux.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 78179989

drivers/gpio/gpiolib.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -226,8 +226,10 @@ static int gpiochip_add_to_list(struct gpio_chip *chip)
		*/

		iterator = list_last_entry(&gpio_chips, struct gpio_chip, list);
		if (iterator->base + iterator->ngpio <= chip->base)
		goto found;
		if (iterator->base + iterator->ngpio <= chip->base) {
		list_add(&chip->list, &iterator->list);
		return 0;
		}

		dev_err(chip->parent,
		"GPIO integer space overlap, cannot add chip\n");

Admin message