Commit 95fb4eb6 authored Jul 29, 2009 by Bartlomiej Zolnierkiewicz Committed by Avi Kivity Sep 10, 2009

KVM: remove superfluous NULL pointer check in kvm_inject_pit_timer_irqs()



This takes care of the following entries from Dan's list:

arch/x86/kvm/i8254.c +714 kvm_inject_pit_timer_irqs(6) warning: variable derefenced in initializer 'vcpu'
arch/x86/kvm/i8254.c +714 kvm_inject_pit_timer_irqs(6) warning: variable derefenced before check 'vcpu'

Reported-by: Dan Carpenter <error27@gmail.com>
Cc: corbet@lwn.net
Cc: eteo@redhat.com
Cc: Julia Lawall <julia@diku.dk>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sheng Yang <sheng@linux.intel.com>
Signed-off-by: Avi Kivity <avi@redhat.com>

parent 344f414f

arch/x86/kvm/i8254.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -713,7 +713,7 @@ void kvm_inject_pit_timer_irqs(struct kvm_vcpu *vcpu)
		struct kvm *kvm = vcpu->kvm;
		struct kvm_kpit_state *ps;

		if (vcpu && pit) {
		if (pit) {
		int inject = 0;
		ps = &pit->pit_state;

Admin message