Commit 95f89e09 authored Oct 15, 2019 by Joerg Roedel Committed by Alex Williamson Oct 15, 2019

vfio/type1: Initialize resv_msi_base



After enabling CONFIG_IOMMU_DMA on X86 a new warning appears when
compiling vfio:

drivers/vfio/vfio_iommu_type1.c: In function ‘vfio_iommu_type1_attach_group’:
drivers/vfio/vfio_iommu_type1.c:1827:7: warning: ‘resv_msi_base’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   ret = iommu_get_msi_cookie(domain->domain, resv_msi_base);
   ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The warning is a false positive, because the call to iommu_get_msi_cookie()
only happens when vfio_iommu_has_sw_msi() returned true. And that only
happens when it also set resv_msi_base.

But initialize the variable anyway to get rid of the warning.

Signed-off-by: Joerg Roedel <jroedel@suse.de>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>

parent 4f5cafb5

drivers/vfio/vfio_iommu_type1.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1658,7 +1658,7 @@ static int vfio_iommu_type1_attach_group(void *iommu_data,
		struct bus_type *bus = NULL;
		int ret;
		bool resv_msi, msi_remap;
		phys_addr_t resv_msi_base;
		phys_addr_t resv_msi_base = 0;
		struct iommu_domain_geometry geo;
		LIST_HEAD(iova_copy);
		LIST_HEAD(group_resv_regions);

Admin message