Commit 95f59bf8 authored May 14, 2020 by Madhuparna Bhowmik Committed by David S. Miller May 14, 2020

drivers: net: hamradio: Fix suspicious RCU usage warning in bpqether.c



This patch fixes the following warning:
=============================
WARNING: suspicious RCU usage
5.7.0-rc5-next-20200514-syzkaller #0 Not tainted
-----------------------------
drivers/net/hamradio/bpqether.c:149 RCU-list traversed in non-reader section!!

Since rtnl lock is held, pass this cond in list_for_each_entry_rcu().

Reported-by:  <syzbot+bb82cafc737c002d11ca@syzkaller.appspotmail.com>
Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent cc8a677a

drivers/net/hamradio/bpqether.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -127,7 +127,8 @@ static inline struct net_device bpq_get_ax25_dev(struct net_device dev)
		{
		struct bpqdev *bpq;

		list_for_each_entry_rcu(bpq, &bpq_devices, bpq_list) {
		list_for_each_entry_rcu(bpq, &bpq_devices, bpq_list,
		lockdep_rtnl_is_held()) {
		if (bpq->ethdev == dev)
		return bpq->axdev;
		}

Admin message