Commit 95e32f86 authored Jul 14, 2020 by Mathieu Poirier Committed by Bjorn Andersson Jul 17, 2020

remoteproc: stm32: Remove memory translation from DT parsing



Other than one has to be done after the other, there is no correlation
between memory translation and DT parsing.  As such move function
stm32_rproc_of_memory_translations() to stm32_rproc_probe() so that
stm32_rproc_parse_dt() can be extended to look for attach bindings
in a clean way.

Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Reviewed-by: Loic Pallardy <loic.pallardy@st.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20200714200445.1427257-5-mathieu.poirier@linaro.org


Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

parent 8210fc87

drivers/remoteproc/stm32_rproc.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -607,7 +607,7 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev,

		*auto_boot = of_property_read_bool(np, "st,auto-boot");

		return stm32_rproc_of_memory_translations(pdev, ddata);
		return 0;
		}

		static int stm32_rproc_probe(struct platform_device *pdev)
		@@ -634,6 +634,10 @@ static int stm32_rproc_probe(struct platform_device *pdev)
		if (ret)
		goto free_rproc;

		ret = stm32_rproc_of_memory_translations(pdev, ddata);
		if (ret)
		goto free_rproc;

		rproc->has_iommu = false;
		ddata->workqueue = create_workqueue(dev_name(dev));
		if (!ddata->workqueue) {

Admin message