Commit 95e2a3b3 authored Sep 16, 2017 by Jan H. Schönherr Committed by Radim Krčmář Sep 19, 2017

Revert "KVM: Don't accept obviously wrong gsi values via KVM_IRQFD"



This reverts commit 36ae3c0a.

The commit broke compilation on !CONFIG_HAVE_KVM_IRQ_ROUTING. Also,
there may be cases with CONFIG_HAVE_KVM_IRQ_ROUTING, where larger
gsi values make sense.

As the commit was meant as an early indicator to user space that
something is wrong, reverting just restores the previous behavior
where overly large values are ignored when encountered (without
any direct feedback).

Reported-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
Signed-off-by: Jan H. Schönherr <jschoenh@amazon.de>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>

parent 2bd6bf03

virt/kvm/eventfd.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -565,8 +565,6 @@ kvm_irqfd(struct kvm kvm, struct kvm_irqfd args)
		{
		if (args->flags & ~(KVM_IRQFD_FLAG_DEASSIGN \| KVM_IRQFD_FLAG_RESAMPLE))
		return -EINVAL;
		if (args->gsi >= KVM_MAX_IRQ_ROUTES)
		return -EINVAL;

		if (args->flags & KVM_IRQFD_FLAG_DEASSIGN)
		return kvm_irqfd_deassign(kvm, args);

Admin message