Commit 95da0c19 authored by Ludovic Desroches's avatar Ludovic Desroches Committed by Vinod Koul
Browse files

dmaengine: at_xdmac: fix spurious flag status for mem2mem transfers 



When setting the channel configuration register, the perid field is not
set to 0 since it is useless for mem2mem transfers. Unfortunately, a
device has 0 as perid. It could cause spurious flags status because
the controller could mix some events from the two channels.
For that reason, use the highest perid value for mem2mem transfers since it
doesn't match the perid of other devices.

Signed-off-by: default avatarLudovic Desroches <ludovic.desroches@atmel.com>
Acked-by: default avatarNicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent d9f5efad

drivers/dma/at_xdmac.c

+15 −3
Original line number Diff line number Diff line
@@ -863,8 +863,12 @@ at_xdmac_interleaved_queue_desc(struct dma_chan *chan, 
	 * access. Hopefully we can access DDR through both ports (at least on

	 * SAMA5D4x), so we can use the same interface for source and dest,

	 * that solves the fact we don't know the direction.

	 * ERRATA: Even if useless for memory transfers, the PERID has to not

	 * match the one of another channel. If not, it could lead to spurious

	 * flag status.

	 */

	u32			chan_cc = AT_XDMAC_CC_DIF(0)

	u32			chan_cc = AT_XDMAC_CC_PERID(0x3f)

					| AT_XDMAC_CC_DIF(0)

					| AT_XDMAC_CC_SIF(0)

					| AT_XDMAC_CC_MBSIZE_SIXTEEN

					| AT_XDMAC_CC_TYPE_MEM_TRAN;
@@ -1039,8 +1043,12 @@ at_xdmac_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest, dma_addr_t src, 
	 * access DDR through both ports (at least on SAMA5D4x), so we can use

	 * the same interface for source and dest, that solves the fact we

	 * don't know the direction.

	 * ERRATA: Even if useless for memory transfers, the PERID has to not

	 * match the one of another channel. If not, it could lead to spurious

	 * flag status.

	 */

	u32			chan_cc = AT_XDMAC_CC_DAM_INCREMENTED_AM

	u32			chan_cc = AT_XDMAC_CC_PERID(0x3f)

					| AT_XDMAC_CC_DAM_INCREMENTED_AM

					| AT_XDMAC_CC_SAM_INCREMENTED_AM

					| AT_XDMAC_CC_DIF(0)

					| AT_XDMAC_CC_SIF(0)
@@ -1140,8 +1148,12 @@ static struct at_xdmac_desc *at_xdmac_memset_create_desc(struct dma_chan *chan, 
	 * access. Hopefully we can access DDR through both ports (at least on

	 * SAMA5D4x), so we can use the same interface for source and dest,

	 * that solves the fact we don't know the direction.

	 * ERRATA: Even if useless for memory transfers, the PERID has to not

	 * match the one of another channel. If not, it could lead to spurious

	 * flag status.

	 */

	u32			chan_cc = AT_XDMAC_CC_DAM_UBS_AM

	u32			chan_cc = AT_XDMAC_CC_PERID(0x3f)

					| AT_XDMAC_CC_DAM_UBS_AM

					| AT_XDMAC_CC_SAM_INCREMENTED_AM

					| AT_XDMAC_CC_DIF(0)

					| AT_XDMAC_CC_SIF(0)

CRA Git | Maintained and supported by SUSTech CRA and CCSE