Commit 95d35cb4 authored by Trond Myklebust's avatar Trond Myklebust
Browse files

NFSv4: Remove nfs_client->cl_sem 



Now that we're using the flags to indicate state that needs to be
recovered, as well as having implemented proper refcounting and spinlocking
on the state and open_owners, we can get rid of nfs_client->cl_sem. The
only remaining case that was dubious was the file locking, and that case is
now covered by the nfsi->rwsem.

Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent 19e03c57

fs/nfs/client.c

+0 −1
Original line number Diff line number Diff line
@@ -143,7 +143,6 @@ static struct nfs_client *nfs_alloc_client(const struct nfs_client_initdata *cl_ 
	clp->cl_proto = cl_init->proto;



#ifdef CONFIG_NFS_V4

	init_rwsem(&clp->cl_sem);

	INIT_LIST_HEAD(&clp->cl_delegations);

	spin_lock_init(&clp->cl_lock);

	INIT_DELAYED_WORK(&clp->cl_renewd, nfs4_renew_state);

fs/nfs/delegation.c

+0 −5
Original line number Diff line number Diff line
@@ -243,16 +243,13 @@ static void nfs_msync_inode(struct inode *inode) 
 */

static int __nfs_inode_return_delegation(struct inode *inode, struct nfs_delegation *delegation)

{

	struct nfs_client *clp = NFS_SERVER(inode)->nfs_client;

	struct nfs_inode *nfsi = NFS_I(inode);



	nfs_msync_inode(inode);

	down_read(&clp->cl_sem);

	/* Guard against new delegated open calls */

	down_write(&nfsi->rwsem);

	nfs_delegation_claim_opens(inode, &delegation->stateid);

	up_write(&nfsi->rwsem);

	up_read(&clp->cl_sem);

	nfs_msync_inode(inode);



	return nfs_do_return_delegation(inode, delegation, 1);
@@ -425,7 +422,6 @@ static int recall_thread(void *data) 
	daemonize("nfsv4-delegreturn");



	nfs_msync_inode(inode);

	down_read(&clp->cl_sem);

	down_write(&nfsi->rwsem);

	spin_lock(&clp->cl_lock);

	delegation = nfs_detach_delegation_locked(nfsi, args->stateid);
@@ -437,7 +433,6 @@ static int recall_thread(void *data) 
	complete(&args->started);

	nfs_delegation_claim_opens(inode, args->stateid);

	up_write(&nfsi->rwsem);

	up_read(&clp->cl_sem);

	nfs_msync_inode(inode);



	if (delegation != NULL)

fs/nfs/nfs4proc.c

+1 −19
Original line number Diff line number Diff line
@@ -207,12 +207,8 @@ static int nfs4_wait_clnt_recover(struct nfs_client *clp) 


	might_sleep();



	rwsem_acquire(&clp->cl_sem.dep_map, 0, 0, _RET_IP_);



	res = wait_on_bit(&clp->cl_state, NFS4CLNT_STATE_RECOVER,

			nfs4_wait_bit_killable, TASK_KILLABLE);



	rwsem_release(&clp->cl_sem.dep_map, 1, _RET_IP_);

	return res;

}
@@ -1135,7 +1131,6 @@ static int _nfs4_do_open(struct inode *dir, struct path *path, int flags, struct 
	struct nfs4_state_owner  *sp;

	struct nfs4_state     *state = NULL;

	struct nfs_server       *server = NFS_SERVER(dir);

	struct nfs_client *clp = server->nfs_client;

	struct nfs4_opendata *opendata;

	int status;
@@ -1150,11 +1145,10 @@ static int _nfs4_do_open(struct inode *dir, struct path *path, int flags, struct 
		goto err_put_state_owner;

	if (path->dentry->d_inode != NULL)

		nfs4_return_incompatible_delegation(path->dentry->d_inode, flags & (FMODE_READ|FMODE_WRITE));

	down_read(&clp->cl_sem);

	status = -ENOMEM;

	opendata = nfs4_opendata_alloc(path, sp, flags, sattr);

	if (opendata == NULL)

		goto err_release_rwsem;

		goto err_put_state_owner;



	if (path->dentry->d_inode != NULL)

		opendata->state = nfs4_get_open_state(path->dentry->d_inode, sp);
@@ -1172,13 +1166,10 @@ static int _nfs4_do_open(struct inode *dir, struct path *path, int flags, struct 
		goto err_opendata_put;

	nfs4_opendata_put(opendata);

	nfs4_put_state_owner(sp);

	up_read(&clp->cl_sem);

	*res = state;

	return 0;

err_opendata_put:

	nfs4_opendata_put(opendata);

err_release_rwsem:

	up_read(&clp->cl_sem);

err_put_state_owner:

	nfs4_put_state_owner(sp);

out_err:
@@ -3099,7 +3090,6 @@ static int _nfs4_proc_getlk(struct nfs4_state *state, int cmd, struct file_lock 
	struct nfs4_lock_state *lsp;

	int status;



	down_read(&clp->cl_sem);

	arg.lock_owner.clientid = clp->cl_clientid;

	status = nfs4_set_lock_state(state, request);

	if (status != 0)
@@ -3116,7 +3106,6 @@ static int _nfs4_proc_getlk(struct nfs4_state *state, int cmd, struct file_lock 
	}

	request->fl_ops->fl_release_private(request);

out:

	up_read(&clp->cl_sem);

	return status;

}
@@ -3273,7 +3262,6 @@ static struct rpc_task *nfs4_do_unlck(struct file_lock *fl, 


static int nfs4_proc_unlck(struct nfs4_state *state, int cmd, struct file_lock *request)

{

	struct nfs_client *clp = state->owner->so_client;

	struct nfs_inode *nfsi = NFS_I(state->inode);

	struct nfs_seqid *seqid;

	struct nfs4_lock_state *lsp;
@@ -3284,15 +3272,12 @@ static int nfs4_proc_unlck(struct nfs4_state *state, int cmd, struct file_lock * 
	status = nfs4_set_lock_state(state, request);

	/* Unlock _before_ we do the RPC call */

	request->fl_flags |= FL_EXISTS;

	down_read(&clp->cl_sem);

	down_read(&nfsi->rwsem);

	if (do_vfs_lock(request->fl_file, request) == -ENOENT) {

		up_read(&nfsi->rwsem);

		up_read(&clp->cl_sem);

		goto out;

	}

	up_read(&nfsi->rwsem);

	up_read(&clp->cl_sem);

	if (status != 0)

		goto out;

	/* Is this a delegated lock? */
@@ -3518,7 +3503,6 @@ static int nfs4_lock_expired(struct nfs4_state *state, struct file_lock *request 


static int _nfs4_proc_setlk(struct nfs4_state *state, int cmd, struct file_lock *request)

{

	struct nfs_client *clp = state->owner->so_client;

	struct nfs_inode *nfsi = NFS_I(state->inode);

	unsigned char fl_flags = request->fl_flags;

	int status;
@@ -3531,7 +3515,6 @@ static int _nfs4_proc_setlk(struct nfs4_state *state, int cmd, struct file_lock 
	status = do_vfs_lock(request->fl_file, request);

	if (status < 0)

		goto out;

	down_read(&clp->cl_sem);

	down_read(&nfsi->rwsem);

	if (test_bit(NFS_DELEGATED_STATE, &state->flags)) {

		/* Yes: cache locks! */
@@ -3549,7 +3532,6 @@ static int _nfs4_proc_setlk(struct nfs4_state *state, int cmd, struct file_lock 
		printk(KERN_WARNING "%s: VFS is out of sync with lock manager!\n", __func__);

out_unlock:

	up_read(&nfsi->rwsem);

	up_read(&clp->cl_sem);

out:

	request->fl_flags = fl_flags;

	return status;

fs/nfs/nfs4renewd.c

+0 −3
Original line number Diff line number Diff line
@@ -65,7 +65,6 @@ nfs4_renew_state(struct work_struct *work) 
	long lease, timeout;

	unsigned long last, now;



	down_read(&clp->cl_sem);

	dprintk("%s: start\n", __func__);

	/* Are there any active superblocks? */

	if (list_empty(&clp->cl_superblocks))
@@ -101,11 +100,9 @@ nfs4_renew_state(struct work_struct *work) 
	schedule_delayed_work(&clp->cl_renewd, timeout);

	spin_unlock(&clp->cl_lock);

out:

	up_read(&clp->cl_sem);

	dprintk("%s: done\n", __func__);

}



/* Must be called with clp->cl_sem locked for writes */

void

nfs4_schedule_state_renewal(struct nfs_client *clp)

{

fs/nfs/nfs4state.c

+0 −17
Original line number Diff line number Diff line
@@ -305,10 +305,6 @@ nfs4_drop_state_owner(struct nfs4_state_owner *sp) 
	}

}



/*

 * Note: must be called with clp->cl_sem held in order to prevent races

 *       with reboot recovery!

 */

struct nfs4_state_owner *nfs4_get_state_owner(struct nfs_server *server, struct rpc_cred *cred)

{

	struct nfs_client *clp = server->nfs_client;
@@ -337,10 +333,6 @@ struct nfs4_state_owner *nfs4_get_state_owner(struct nfs_server *server, struct 
	return sp;

}



/*

 * Must be called with clp->cl_sem held in order to avoid races

 * with state recovery...

 */

void nfs4_put_state_owner(struct nfs4_state_owner *sp)

{

	struct nfs_client *clp = sp->so_client;
@@ -442,10 +434,6 @@ out: 
	return state;

}



/*

 * Beware! Caller must be holding exactly one

 * reference to clp->cl_sem!

 */

void nfs4_put_open_state(struct nfs4_state *state)

{

	struct inode *inode = state->inode;
@@ -578,7 +566,6 @@ static void nfs4_free_lock_state(struct nfs4_lock_state *lsp) 
 * Return a compatible lock_state. If no initialized lock_state structure

 * exists, return an uninitialized one.

 *

 * The caller must be holding clp->cl_sem

 */

static struct nfs4_lock_state *nfs4_get_lock_state(struct nfs4_state *state, fl_owner_t owner)

{
@@ -1127,7 +1114,6 @@ static int reclaimer(void *ptr) 
	allow_signal(SIGKILL);



	/* Ensure exclusive access to NFSv4 state */

	down_write(&clp->cl_sem);

	while (!list_empty(&clp->cl_superblocks)) {

		if (test_and_clear_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state)) {

			/* We're going to have to re-establish a clientid */
@@ -1149,7 +1135,6 @@ static int reclaimer(void *ptr) 


		/* First recover reboot state... */

		if (test_and_clear_bit(NFS4CLNT_RECLAIM_REBOOT, &clp->cl_state)) {

			/* Note: list is protected by exclusive lock on cl->cl_sem */

			status = nfs4_do_reclaim(clp, &nfs4_reboot_recovery_ops);

			if (status == -NFS4ERR_STALE_CLIENTID)

				continue;
@@ -1159,7 +1144,6 @@ static int reclaimer(void *ptr) 


		/* Now recover expired state... */

		if (test_and_clear_bit(NFS4CLNT_RECLAIM_NOGRACE, &clp->cl_state)) {

			/* Note: list is protected by exclusive lock on cl->cl_sem */

			status = nfs4_do_reclaim(clp, &nfs4_nograce_recovery_ops);

			if (status < 0) {

				set_bit(NFS4CLNT_RECLAIM_NOGRACE, &clp->cl_state);
@@ -1175,7 +1159,6 @@ static int reclaimer(void *ptr) 
		break;

	}

out:

	up_write(&clp->cl_sem);

	if (test_and_clear_bit(NFS4CLNT_CB_PATH_DOWN, &clp->cl_state))

		nfs_handle_cb_pathdown(clp);

	nfs4_clear_recover_bit(clp);

CRA Git | Maintained and supported by SUSTech CRA and CCSE