Commit 95d1c8e5 authored Sep 02, 2020 by Jiufei Xue Committed by Jens Axboe Sep 02, 2020

io_uring: set table->files[i] to NULL when io_sqe_file_register failed



While io_sqe_file_register() failed in __io_sqe_files_update(),
table->files[i] still point to the original file which may freed
soon, and that will trigger use-after-free problems.

Cc: stable@vger.kernel.org
Fixes: f3bd9dae ("io_uring: fix memleak in __io_sqe_files_update()")
Signed-off-by: Jiufei Xue <jiufei.xue@linux.alibaba.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 98dfd502

fs/io_uring.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -7353,6 +7353,7 @@ static int __io_sqe_files_update(struct io_ring_ctx *ctx,
		table->files[index] = file;
		err = io_sqe_file_register(ctx, file, i);
		if (err) {
		table->files[index] = NULL;
		fput(file);
		break;
		}

Admin message